Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to the module system, which separates public and private scope per https://lean-lang.org/doc/reference/latest/Source-Files-and-Modules/#module-scopes. I marked most library functions with
public sectionto prevent breaking changes for now, but internal functions can be marked asprivate defs so they aren't exported to other modules or downstream.Merge after argumentcomputer/Blake3.lean#30 and argumentcomputer/LSpec#74